Refactor final4 paths to graph-derived structure#24
Closed
Conversation
Owner
Author
|
Superseded by #29, which has now been squashed and merged. Closing this predecessor PR to keep the active history clean. |
Owner
Author
|
Superseded by merged #29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Derive Final Four and region-winner bracket paths from game-graph data instead of fixed game IDs.
Why
Hardcoded path IDs make bracket-year maintenance brittle and force structural assumptions into controller/validation code.
How
Added a
Bracket::Service::BracketStructureservice that infers championship, semifinal, and region-winner paths fromgame_graph+game_team_graphancestry.Wired
Final4controller stash loading andBracketValidatorfinal-four scope checks to this service.Added structure-focused tests and updated validator tests to assert behavior via derived game IDs.
Testing
script/test-env.sh prove -lv t/bracket_structure.t t/bracket_validator.tscript/test-env.sh prove -lr tQuality Report
Changes: 5 files changed, 215 insertions(+), 27 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline