Perf/allocation optimizations for FastLabelPropagationCommunityDetector.AssignLabels#5
Merged
KSemenenko merged 3 commits intomanagedcode:mainfrom Dec 6, 2025
Merged
Conversation
…Labels. Adding perf/allocation optimizations
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 75.34% 75.24% -0.11%
==========================================
Files 115 115
Lines 4734 4751 +17
Branches 797 798 +1
==========================================
+ Hits 3567 3575 +8
- Misses 851 861 +10
+ Partials 316 315 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I absolutely love your work! Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed Cache benchmark as it's not adding much value, it benchmarks operations on in memory cache.
Added test coverage for
FastLabelPropagationCommunityDetector.AssignLabelsmethod.Applied perf/allocation improvements to
AssignLabelsmethod.Proposed Changes
Applying small tweaks to reduce allocations, by using
random.shuffleto shuffle in-place instead of creating a new list. Also movedlabelWeightsdictionary creation outside of the loop to reduce allocations further.BenchmarkDotNet results:
Which are big in allocation improvement & up to 20 % performance improvement.
Checklist
Additional Notes
N/A