Fix some exporter inheritance mistakes and add more BVH export options#237
Open
PierceLBrooks wants to merge 1 commit intomakehumancommunity:masterfrom
Open
Fix some exporter inheritance mistakes and add more BVH export options#237PierceLBrooks wants to merge 1 commit intomakehumancommunity:masterfrom
PierceLBrooks wants to merge 1 commit intomakehumancommunity:masterfrom
Conversation
…nality with extra options for misc downstream project pipeline compliance
Contributor
|
Thanks. I've looked at this and it seems sensible. I've also done some cursory testing with exporting and opening a pose with and without your changes, and with and with the checkboxes in various states. I see no downsides of this. I'll just ask someone else in the dev group take a look at it too before merging. |
Author
|
@joepal1976 , are there any further actions that are needed from my end? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will resolve some confusion surrounding the "Feet On Ground" export option for various asset file formats, as well as introduce extra options when exporting the animation/pose skeleton as BVH. This includes the exposure of "Dummy Joints" which before were always enabled by default, therefore unconditionally guaranteeing that the automated joint name retargeting procedure for whichever template was selected by the user will never yield discontiguous bones. Users should ideally be able to elect whether to exclude dummy joints, whose names feature a double under-score "__" prefix which can disrupt parity with certain skeleton templates such as the one for CMU motion capture data, and so it has been addressed here. Additionally, for the convenience of working within a project pipeline where animators must share motion data between different armatures in other tools outside the context of MakeHuman itself, a "Sort Joint Children By Name" option is also introduced so that the order of appearance for each child of a given joint node in the resultant BVH data is deterministic according to alphabetical sorting.