Fixed: page jumps up/down when using arrow keys#37
Open
evgeni-spasov wants to merge 1 commit intomadrobby:masterfrom
Open
Fixed: page jumps up/down when using arrow keys#37evgeni-spasov wants to merge 1 commit intomadrobby:masterfrom
evgeni-spasov wants to merge 1 commit intomadrobby:masterfrom
Conversation
When using the up and down arrow keys the page is scrolled repeatedly. This fix checks if autocomplete selection is in browser viewport and scrolls page only needed.
|
this won't fix. If you have a scrollable page, if you go after searching at the bottom of page and use arrows, the result list position is wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the up and down arrow keys the page is scrolled repeatedly.
This fix checks if autocomplete selection is in browser viewport and
scrolls page only needed.