Skip to content

Fix DEPTHAI_VCPKG_INTERNAL_ONLY option #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amronos wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −3
Open

Fix DEPTHAI_VCPKG_INTERNAL_ONLY option #1741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmake/depthaiOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ option(DEPTHAI_INSTALL "Enable install target for depthai-core targets" ON)

# ---------- Dependency Management -------------
option(DEPTHAI_BOOTSTRAP_VCPKG "Automatically bootstrap VCPKG" ON)
option(DEPTHAI_VCPKG_INTERNAL_ONLY "Use VCPKG internally, but not for interface libraries" ON)
option(DEPTHAI_VCPKG_INTERNAL_ONLY "Use VCPKG internally, but not for interface libraries" OFF)
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Clarify the option help text for maintainability.

Consider making the description explicit about effect (e.g., when enabled, interface deps default to DEPTHAI_*_EXTERNAL=ON via find_package) to avoid future regressions.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@cmake/depthaiOptions.cmake` at line 45, The option
DEPTHAI_VCPKG_INTERNAL_ONLY has an ambiguous help string; update its description
to explicitly state behavior when enabled—e.g., that enabling
DEPTHAI_VCPKG_INTERNAL_ONLY causes interface dependencies to be resolved
externally by default (sets DEPTHAI_*_EXTERNAL=ON semantics) and that
find_package will be used for those interface libs—so future maintainers
understand its effect and interactions with find_package and DEPTHAI_*_EXTERNAL
variables.


set(USE_EXTERNAL_INTERFACE_LIBS_DEFAULT ON)
set(USE_EXTERNAL_INTERFACE_LIBS_DEFAULT OFF)
if(DEPTHAI_VCPKG_INTERNAL_ONLY)
set(USE_EXTERNAL_INTERFACE_LIBS_DEFAULT OFF)
set(USE_EXTERNAL_INTERFACE_LIBS_DEFAULT ON)
endif()

option(DEPTHAI_JSON_EXTERNAL "Use external nlohmann_json library" ${USE_EXTERNAL_INTERFACE_LIBS_DEFAULT})
Expand Down