Skip to content

fix: recognize Windows absolute drive paths (C:\...) in isLocalPath#139

Open
Mordris wants to merge 2 commits intoluongnv89:mainfrom
Mordris:fix/138-windows-drive-paths
Open

fix: recognize Windows absolute drive paths (C:\...) in isLocalPath#139
Mordris wants to merge 2 commits intoluongnv89:mainfrom
Mordris:fix/138-windows-drive-paths

Conversation

@Mordris
Copy link
Copy Markdown
Contributor

@Mordris Mordris commented Mar 30, 2026

Closes #138

Description

This PR fixes an issue where Windows absolute drive paths (e.g., C:\Users\...\skill) were not recognized as local sources by the asm install command. The logic was previously biased towards POSIX paths, causing Windows paths to be incorrectly treated as remote GitHub repositories.

Related Issue

Fixes #138

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

(Add any relevant screenshots here)

Additional Notes

The fix uses a regex /^[a-zA-Z]:[/\\]/ to identify Windows drive-letter absolute paths. This ensures compatibility with both standard backslashes and modern forward slashes in Windows environments.

@Mordris Mordris marked this pull request as draft March 30, 2026 07:44
@Mordris Mordris marked this pull request as ready for review March 30, 2026 07:46
@Mordris Mordris force-pushed the fix/138-windows-drive-paths branch from 747248e to b14e0cb Compare March 30, 2026 07:51
@Mordris Mordris marked this pull request as draft March 30, 2026 07:51
@Mordris Mordris marked this pull request as ready for review March 30, 2026 08:12
@luongnv89
Copy link
Copy Markdown
Owner

thank you very much for the PR,
could you please make sure all the CI green?

@Mordris
Copy link
Copy Markdown
Contributor Author

Mordris commented Mar 30, 2026

thank you very much for the PR, could you please make sure all the CI green?

I think these are previous failures. Working on it.

@luongnv89
Copy link
Copy Markdown
Owner

thank you very much for the PR, could you please make sure all the CI green?

I think these are previous failures. Working on it.

could be, i am still in the mid of cooking =))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Windows absolute drive paths (C:\...) are not recognized as local sources

2 participants