fix: recognize Windows absolute drive paths (C:\...) in isLocalPath#139
Open
Mordris wants to merge 2 commits intoluongnv89:mainfrom
Open
fix: recognize Windows absolute drive paths (C:\...) in isLocalPath#139Mordris wants to merge 2 commits intoluongnv89:mainfrom
Mordris wants to merge 2 commits intoluongnv89:mainfrom
Conversation
747248e to
b14e0cb
Compare
Owner
|
thank you very much for the PR, |
Contributor
Author
I think these are previous failures. Working on it. |
Owner
could be, i am still in the mid of cooking =)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138
Description
This PR fixes an issue where Windows absolute drive paths (e.g.,
C:\Users\...\skill) were not recognized as local sources by theasm installcommand. The logic was previously biased towards POSIX paths, causing Windows paths to be incorrectly treated as remote GitHub repositories.Related Issue
Fixes #138
Type of Change
Checklist
Screenshots (if applicable)
(Add any relevant screenshots here)
Additional Notes
The fix uses a regex
/^[a-zA-Z]:[/\\]/to identify Windows drive-letter absolute paths. This ensures compatibility with both standard backslashes and modern forward slashes in Windows environments.