Add support for browser and platform allowlists#1
Open
Conversation
jadenPete
force-pushed
the
jpeterson-adds-support-for-platform-allowlists
branch
from
4e71e1f to
c7d2b90
Compare
jadenPete
changed the title
jjudd
reviewed
Apr 1, 2026
jjudd
left a comment
jjudd
left a comment
There was a problem hiding this comment.
Thanks for doing this. Had a few questions.
Cross-compilation for MacOS wasn't working with `toolchains_llvm`, so I switched us to `toolchains_llvm_bootstrapped`. This toolchain also has the advantage of being more hermetic and downloading less. In order to do this, I had to upgrade `rules_rust` to v0.69.0, as older versions aren't compatible with the linker `toolchains_llvm_boostrapped` supplies. Finally, I added `/bazel/bazel_downloader.cfg` to `.gitignore` so we can configure the Bazel downloader to use our corporate cache, as I'm unable to download the MacOS toolchain doesn't without it.
jadenPete
force-pushed
the
jpeterson-adds-support-for-platform-allowlists
branch
from
c7d2b90 to
bd03ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, Bazel is downloading
rules_playwrightbrowsers, causing many warnings to appear that they're missing integrity values. It's also probably slowing down our builds. This PR addsallowed_browsersandallowed_platformsoptions torules_playwright's module extension that allow us to configure which browser names and platforms it declares browsers for.It also includes the changes from this one, which are necessary for us to use newer versions of Playwright:
mrmeku#36