test: fix Jetty 12 RuntimeIOException deprecation and Windows POSIX c…#118
Open
Yosefnago wants to merge 1 commit intologzio:masterfrom
Open
test: fix Jetty 12 RuntimeIOException deprecation and Windows POSIX c…#118Yosefnago wants to merge 1 commit intologzio:masterfrom
Yosefnago wants to merge 1 commit intologzio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the local test environment setup to allow running tests on Windows machines, and replaces a deprecated Jetty API.
Previous behavior:
TestEnvironment.createTempDirectory()threw anUnsupportedOperationExceptionon Windows due to hardcoded POSIX file permissions (NTFS does not support them).MockLogzioBulkListenerusedorg.eclipse.jetty.io.RuntimeIOExceptionwhich is deprecated for removal in Jetty 12.New behavior:
Checks if
posixis supported by the underlying file system (FileSystems.getDefault().supportedFileAttributeViews()) before applying POSIX attributes. On Windows, it falls back to standard directory creation, while maintaining original behavior on Linux/Unix/CI environments.Uses the standard
java.io.UncheckedIOExceptioninstead of the deprecated Jetty class.What type of PR is this?
(check all applicable)
Added tests?