ec2: Add support for security groups from NetworkInterfaces in RunInstances#145
Open
nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
Conversation
nik-localstack
force-pushed
the
unc-383-bug-ec2-instances-created-from-launch-templates-with
branch
2 times, most recently
from
4643b6c to
cc5fd0c
Compare
nik-localstack
force-pushed
the
unc-383-bug-ec2-instances-created-from-launch-templates-with
branch
from
cc5fd0c to
9756b45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When launching an instance using a launch template that specifies security groups via
NetworkInterfaces[].Groups(as tools like Karpenter do), the resulting instance'sSecurityGroupsfield was always empty inDescribeInstances. This is becauserun_instancesonly copiedSecurityGroupIdsfrom the launch template, not the groups embedded in network interfaces.The same issue affected
NetworkInterfacespassed directly in aRunInstancesrequest.This PR fixes both cases by collecting security groups from
NetworkInterfaces[].Groupswhen no top-levelSecurityGroupIdsare present.