Solve the compatibility problem of SeparatorStyle.CHATML type messes field#3278
Open
icowan wants to merge 41 commits intolm-sys:mainfrom
Open
Solve the compatibility problem of SeparatorStyle.CHATML type messes field#3278icowan wants to merge 41 commits intolm-sys:mainfrom
icowan wants to merge 41 commits intolm-sys:mainfrom
Conversation
…field Solve the compatibility problem of SeparatorStyle.CHATML type messes field /usr/local/lib/python3.10/dist-packages/fastchat/conversation.py", line 197, in get_prompt ERROR | stderr | ret += role + ":" + message + seps[i % 2] + "\n" ERROR | stderr | TypeError: can only concatenate str (not "NoneType") to str
Solve the compatibility problem of SeparatorStyle.CHATML type messes …
UI Improvements: unified link color, removed link underline, made win…
# Conflicts: # fastchat/conversation.py
# Conflicts: # fastchat/conversation.py # fastchat/serve/openai_api_server.py
# Conflicts: # docs/arena.md # fastchat/conversation.py # fastchat/serve/gradio_block_arena_anony.py # fastchat/serve/gradio_block_arena_named.py # fastchat/serve/gradio_block_arena_vision.py # fastchat/serve/gradio_block_arena_vision_anony.py # fastchat/serve/gradio_block_arena_vision_named.py # fastchat/serve/gradio_web_server.py # fastchat/utils.py
Add max-model-len argument to vllm worker (lm-sys#3451)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Solve the compatibility problem of SeparatorStyle.CHATML type messes field
/usr/local/lib/python3.10/dist-packages/fastchat/conversation.py", line 197, in get_prompt
ERROR | stderr | ret += role + ":" + message + seps[i % 2] + "\n"
ERROR | stderr | TypeError: can only concatenate str (not "NoneType") to str
Checks
format.shto lint the changes in this PR.