[Networking] internalfabric getter name refactoring#3083
Open
cheina97 wants to merge 1 commit intoliqotech:masterfrom
Open
[Networking] internalfabric getter name refactoring#3083cheina97 wants to merge 1 commit intoliqotech:masterfrom
cheina97 wants to merge 1 commit intoliqotech:masterfrom
Conversation
cheina97
force-pushed
the
frc/internalfabric
branch
from
31c797c to
30e5d13
Compare
Collaborator
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
github-actions
bot
added
the
refactor
cheina97
force-pushed
the
master
branch
2 times, most recently
from
bec7493 to
2f76836
Compare
adamjensenbot
force-pushed
the
frc/internalfabric
branch
from
30e5d13 to
411f755
Compare
cheina97
force-pushed
the
frc/internalfabric
branch
2 times, most recently
from
2aa017f to
517ec20
Compare
cheina97
changed the title
cheina97
added
the
release-1.1
cheina97
force-pushed
the
frc/internalfabric
branch
from
517ec20 to
8d105d3
Compare
Member
Author
|
/rebase test=true |
1 similar comment
Member
Author
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/internalfabric
branch
from
8d105d3 to
c9e832d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic used by getInternalFabric to get the internalfabric name. We have a function called ForgeInternalFabricName which is already used in other code places.