Skip to content

Configure Dr Elephant to publish artifacts to Jfrog Bintray#680

Draft
saniyanajeeb wants to merge 5 commits intolinkedin:tuning_20190221from
saniyanajeeb:TOOLS-251167
Draft

Configure Dr Elephant to publish artifacts to Jfrog Bintray#680
saniyanajeeb wants to merge 5 commits intolinkedin:tuning_20190221from
saniyanajeeb:TOOLS-251167

Conversation

@saniyanajeeb
Copy link
Copy Markdown

@saniyanajeeb saniyanajeeb commented Apr 13, 2020

Configuring Dr Elephant to publish artifacts to Jfrog Bintray using sbt-bintray plugin.

Usage instructions how to publish and release the latest version of Dr.Elephant to Bintray:
https://docs.google.com/document/d/1gVHm58ncLYT2YQfZtAxJ5jXGGCc-5GKJKlmnwEP5LvA/edit?usp=sharing

@saniyanajeeb saniyanajeeb changed the title Configure Dr Elephant to publish artifacts to bintray Configure Dr Elephant to publish artifacts to Jfrog Bintray Apr 13, 2020
@ShubhamGupta29
Copy link
Copy Markdown
Contributor

Add a document on how to publish and release the latest version of Dr.Elephant to Bintray which is the aim for this PR.

@saniyanajeeb
Copy link
Copy Markdown
Author

Document on how to publish and release the latest version of Dr.Elephant to Bintray:
https://docs.google.com/document/d/1gVHm58ncLYT2YQfZtAxJ5jXGGCc-5GKJKlmnwEP5LvA/edit?usp=sharing

@@ -1,6 +1,13 @@
/*
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The piwik.js file was being overwritten to this location (track.js) by Dr Elephant MP wrapper. Since the wrapper will be deprecated so adding this file as part of Dr Elephant source code itself.

build.sh Outdated
cd dist/

echo "Uploading the distribution to bintray"
curl -T $MODULE-"$VERSION".zip -u"$1":"$2" https://api.bintray.com/content/linkedin/maven/dr-elephant/"$VERSION"/com/linkedin/drelephant/$MODULE/"$VERSION"/ --verbose
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, $1 and $2 are the username and API key for publishing to Bintray, try to declare them in the Environment variables and use them here, so user not need to provide this information every time they execute this script.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has been updated to get the values of username and API key from environment variables.

@ShubhamGupta29
Copy link
Copy Markdown
Contributor

Document on how to publish and release the latest version of Dr.Elephant to Bintray:
https://docs.google.com/document/d/1gVHm58ncLYT2YQfZtAxJ5jXGGCc-5GKJKlmnwEP5LvA/edit?usp=sharing
It would be better to attach this doc with the PR description as Usage Instruction etc.

@saniyanajeeb saniyanajeeb marked this pull request as draft April 20, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants