feat: enhance error handling with JSON parsing and response truncation#7
Merged
cherkanovart merged 3 commits intomainfrom Feb 4, 2026
Merged
feat: enhance error handling with JSON parsing and response truncation#7cherkanovart merged 3 commits intomainfrom
cherkanovart merged 3 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughAdds two static helpers, Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
vrcprl
approved these changes
Feb 4, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves API error handling when responses are non-JSON (e.g. 502 HTML pages) or very long:
_safe_parse_json()so that when the API returns HTML or other non-JSON (e.g. 502 gateway pages), the code raises a clearRuntimeErrorinstead of a rawJSONDecodeError._truncate_response()so error messages use a short preview (e.g. 200 chars +...) instead of dumping the full response body.Request failed (401): {"message":"Invalid credentials."}).Used in
_localize_chunk,recognize_locale, andwhoami. New unit tests cover the helpers and mocked 502/HTML and truncation behavior.Type of Change
Testing
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Tests