chore: Sync docs and samples with recent schema changes#314
chore: Sync docs and samples with recent schema changes#314claude[bot] wants to merge 1 commit intomainfrom
Conversation
Update documentation and sample code to match recent OpenAPI schema changes: - Add 12 missing account types to Grid Visualizer (AED, BWP, XAF, BDT, COP, EGP, GHS, GTQ, HTG, JMD, PKR accounts and ETHEREUM_WALLET) - Add UNSUPPORTED and CHECKED_BY_RECEIVING_FI verification statuses to sandbox documentation with test suffixes 106/107 - Fix missing imports in Kotlin sample app for USD, BRL, MXN, GBP account types and ExternalAccountInfoOneOf Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis is a sync/housekeeping PR that brings three peripheral artifacts (Grid Visualizer data, sandbox documentation, and Kotlin sample) up to date with recent OpenAPI schema additions. No application logic changes are involved.
One minor point: sandbox suffix Confidence Score: 5/5Safe to merge — all changes are additive documentation and data sync with no logic modifications. All three files receive purely additive, low-risk changes that align existing artifacts with schema additions already merged elsewhere. No P0 or P1 issues were found. The only open question (missing sandbox suffix 108) is a minor documentation gap that does not block correctness and was already present before this PR. No files require special attention.
|
| Filename | Overview |
|---|---|
| components/grid-visualizer/src/data/account-types.ts | Adds 12 new account type specs (ETHEREUM_WALLET, AED, BWP, XAF, BDT, COP, EGP, GHS, GTQ, HTG, JMD, PKR). Structure is consistent with existing entries; phone country codes, IBAN formats, and payment rail choices appear correct. |
| mintlify/snippets/sandbox-beneficiary-verification.mdx | Adds UNSUPPORTED (106) and CHECKED_BY_RECEIVING_FI (107) rows to the verification status table; content is accurate and matches the BeneficiaryVerificationStatus enum, though suffix 108 remains undocumented (minor, may be intentional). |
| samples/kotlin/src/main/kotlin/com/grid/sample/routes/ExternalAccounts.kt | Adds the 9 previously-missing imports needed by the buildAccountInfo helper (UsdBeneficiary/Info, BrlBeneficiary/Info, MxnBeneficiary/Info, GbpBeneficiary/Info, ExternalAccountInfoOneOf); all added symbols are clearly used in the file. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Sandbox: Create account with 1xx suffix] --> B{Suffix value?}
B -->|102| C[NOT_MATCHED\nName does not match]
B -->|103| D[PARTIAL_MATCH\nFuzzy name match]
B -->|104| E[PENDING\nVerification in progress]
B -->|105| F[400 Error\nInvalid account]
B -->|106 NEW| G[UNSUPPORTED\nRail has no name verification]
B -->|107 NEW| H[CHECKED_BY_RECEIVING_FI\nDeferred to receiving FI]
B -->|109| I[500 Error\nSimulated API error]
B -->|Any other| J[MATCHED\nName matches exactly]
Prompt To Fix All With AI
This is a comment left during a code review.
Path: mintlify/snippets/sandbox-beneficiary-verification.mdx
Line: 9-11
Comment:
**Gap at suffix 108 still undocumented**
The table now covers suffixes 102–107 and 109, but `108` is still absent. Before this PR the gap was larger (106, 107, 108 all missing); now only 108 remains. Is this intentional — i.e., 108 is reserved or not yet implemented in the sandbox — or was it accidentally skipped when adding the new rows? If 108 is intentionally omitted, a brief note (e.g., "108 is reserved") would help developers avoid confusion when they happen to test with that number and get an unexpected `MATCHED` result from the catch-all.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "chore: Sync docs and samples with schema..." | Re-trigger Greptile
| | **106** | `UNSUPPORTED` | Payment rail does not support name verification | | ||
| | **107** | `CHECKED_BY_RECEIVING_FI` | Verification deferred to receiving financial institution (e.g., ACH) | | ||
| | **109** | _(error)_ | Returns `500` — simulated API error | |
There was a problem hiding this comment.
Gap at suffix 108 still undocumented
The table now covers suffixes 102–107 and 109, but 108 is still absent. Before this PR the gap was larger (106, 107, 108 all missing); now only 108 remains. Is this intentional — i.e., 108 is reserved or not yet implemented in the sandbox — or was it accidentally skipped when adding the new rows? If 108 is intentionally omitted, a brief note (e.g., "108 is reserved") would help developers avoid confusion when they happen to test with that number and get an unexpected MATCHED result from the catch-all.
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sandbox-beneficiary-verification.mdx
Line: 9-11
Comment:
**Gap at suffix 108 still undocumented**
The table now covers suffixes 102–107 and 109, but `108` is still absent. Before this PR the gap was larger (106, 107, 108 all missing); now only 108 remains. Is this intentional — i.e., 108 is reserved or not yet implemented in the sandbox — or was it accidentally skipped when adding the new rows? If 108 is intentionally omitted, a brief note (e.g., "108 is reserved") would help developers avoid confusion when they happen to test with that number and get an unexpected `MATCHED` result from the catch-all.
How can I resolve this? If you propose a fix, please make it concise.
Summary
Changes by Area
Grid Visualizer (
components/grid-visualizer/src/data/account-types.ts)Added 12 account types that were present in the OpenAPI ExternalAccountType enum but missing from the visualizer data:
Mintlify Docs (
mintlify/snippets/sandbox-beneficiary-verification.mdx)Added two verification statuses that were in the BeneficiaryVerificationStatus enum but missing from the sandbox testing documentation:
106→ UNSUPPORTED (payment rail doesn't support name verification)107→ CHECKED_BY_RECEIVING_FI (deferred to receiving FI, e.g., ACH)Kotlin Sample (
samples/kotlin/.../ExternalAccounts.kt)Added missing imports required by the buildAccountInfo helper function:
Test plan
npm run buildincomponents/grid-visualizermake lint-openapi./gradlew buildinsamples/kotlin🤖 Generated with Claude Code