Skip to content

chore: Sync account schemas#309

Merged
shreyav merged 1 commit intomainfrom
auto/sync-grid-schemas-20260331-222036
Mar 31, 2026
Merged

chore: Sync account schemas#309
shreyav merged 1 commit intomainfrom
auto/sync-grid-schemas-20260331-222036

Conversation

@lightspark-copybara
Copy link
Copy Markdown
Contributor

Auto-synced account schemas.

These schemas are generated from VASP adapter field definitions in sparkcore.

Synced schemas:

  • common/ — per-currency account info, beneficiary, and payment account schemas
  • common/PaymentInstructions.yaml — payment instructions oneOf (new currencies added)
  • external_accounts/ — per-currency external account schemas (reference common/)

Please review the changes before merging.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Mar 31, 2026 10:21pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

chore(internal): regenerate SDK with no functional changes

openapi

feat(api): add BDT/COP/EGP/GHS/GTQ/HTG/JMD/PKR to external account type enum

python

chore(internal): regenerate SDK with no functional changes

typescript

chore(internal): regenerate SDK with no functional changes
⚠️ grid-openapi studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗

⚠️ grid-python studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗build ⏭️lint ⏭️test ✅

⚠️ grid-typescript studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗build ⏭️lint ⏭️test ✅

⚠️ grid-kotlin studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗build ⏭️lint ⏭️test ✅


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-03-31 22:37:59 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 31, 2026

Greptile Summary

This PR extends the ExternalAccountType enum with 8 new currency account types — BDT_ACCOUNT (Bangladeshi Taka), COP_ACCOUNT (Colombian Peso), EGP_ACCOUNT (Egyptian Pound), GHS_ACCOUNT (Ghanaian Cedi), GTQ_ACCOUNT (Guatemalan Quetzal), HTG_ACCOUNT (Haitian Gourde), JMD_ACCOUNT (Jamaican Dollar), and PKR_ACCOUNT (Pakistani Rupee) — synced from VASP adapter field definitions in sparkcore.

Key changes:

  • openapi/components/schemas/external_accounts/ExternalAccountType.yaml — source of truth: 8 new enum values added; enum item indentation reformatted from 2-space to 0-space (cosmetic only, semantically equivalent YAML)
  • openapi.yaml and mintlify/openapi.yaml — generated bundles updated consistently with the same 8 enum additions
  • All supporting per-currency schema files (BdtExternalAccountInfo.yaml, CopExternalAccountInfo.yaml, etc.) already exist in the repository and are already wired into ExternalAccountInfoOneOf.yaml (discriminator mappings) and PaymentInstructions.yaml — no dangling references
  • No P0 or P1 issues found; the sync is clean and fully consistent across source and generated files

Confidence Score: 5/5

Safe to merge — purely additive enum extension with all dependent schema files already in place

All three changed files are consistent with each other. The 8 new enum values have corresponding per-currency schema files, $ref entries in ExternalAccountInfoOneOf.yaml, and discriminator mappings already present in the repo. No breaking changes, no missing references, no logic errors.

No files require special attention

Important Files Changed

Filename Overview
openapi/components/schemas/external_accounts/ExternalAccountType.yaml Adds 8 new currency account enum values (BDT, COP, EGP, GHS, GTQ, HTG, JMD, PKR) and reformats enum items from 2-space indented to 0-space (cosmetic only, both are valid YAML)
openapi.yaml Generated bundle updated with the same 8 new ExternalAccountType enum values; changes are consistent with the source changes
mintlify/openapi.yaml Mintlify-specific generated bundle updated identically to openapi.yaml — 8 new ExternalAccountType enum values added

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ExternalAccountType.yaml\nsource enum] -->|bundled via make build| B[openapi.yaml\ngenerated bundle]
    A -->|bundled via make build| C[mintlify/openapi.yaml\nMintlify bundle]
    A -->|enum values used as discriminator keys| D[ExternalAccountInfoOneOf.yaml\ndiscriminator mapping]
    D --> E[BdtExternalAccountInfo.yaml]
    D --> F[CopExternalAccountInfo.yaml]
    D --> G[EgpExternalAccountInfo.yaml]
    D --> H[GhsExternalAccountInfo.yaml]
    D --> I[GtqExternalAccountInfo.yaml]
    D --> J[HtgExternalAccountInfo.yaml]
    D --> K[JmdExternalAccountInfo.yaml]
    D --> L[PkrExternalAccountInfo.yaml]
    A -->|enum values also used in| M[PaymentInstructions.yaml\noneOf accountOrWalletInfo]
Loading

Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile

@shreyav shreyav merged commit 89905e3 into main Mar 31, 2026
8 checks passed
@shreyav shreyav deleted the auto/sync-grid-schemas-20260331-222036 branch March 31, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant