Skip default config path in tests#125
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Feb 18, 2026
Merged
Conversation
|
I've assigned @tankyleo as a reviewer! |
tnull
reviewed
Feb 16, 2026
ldk-server/src/util/config.rs
Outdated
| Some(PathBuf::from(path)) | ||
| } else { | ||
| get_default_config_path().filter(|path| path.exists()) | ||
| // Skip the default config path during tests to avoid picking up a real ~/.ldk-server/config.toml locally |
Collaborator
There was a problem hiding this comment.
Makes sense, just wondering if this/a similar override should happen in get_default_config_path itself to ensure that it always applies in tests, independent of where it's called?
Collaborator
Author
There was a problem hiding this comment.
This was the only call site but yeah that'll be safer in the long run
Tests calling `load_config` without an explicit `config_file` would fall back to ~`/.ldk-server/config.toml` if it existed locally, causing test failures.
benthecarman
force-pushed
the
fix-test
branch
from
dafa8d4 to
ab005e1
Compare
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
tnull
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests calling
load_configwithout an explicitconfig_filewould fall back to~/.ldk-server/config.tomlif it existed locally, causing test failures.