Skip to content

Fix bug in step size tuning having to do with order of attempt/successs counts#25

Merged
bernstei merged 1 commit intomainfrom
step_size_tuning_param_order
Jun 20, 2025
Merged

Fix bug in step size tuning having to do with order of attempt/successs counts#25
bernstei merged 1 commit intomainfrom
step_size_tuning_param_order

Conversation

@bernstei
Copy link
Copy Markdown
Collaborator

@bernstei bernstei commented Jun 18, 2025

Switch to keeping track of step_size parameters and attempt/success statistics in dicts, rather than arrays, to reduce chance of inconsistencies in the order.

[may want to add a test that fails under the previous behavior]

closes #24

…s counts

Switch to keeping track of step_size parameters and attempt/success
statistics in dicts, rather than arrays, to reduce chance of
inconsistencies in the order, which are what caused
#24
@bernstei
Copy link
Copy Markdown
Collaborator Author

@VGFletcher is this (or #27, which I believe includes these changes) working for you?

@bernstei bernstei merged commit 669e06a into main Jun 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting Up Comparison to Pymatnest

1 participant