Add waterfall display mode (includes changing to canvas-based view)#2
Open
fread wants to merge 4 commits intoleftshift:masterfrom
Open
Add waterfall display mode (includes changing to canvas-based view)#2fread wants to merge 4 commits intoleftshift:masterfrom
fread wants to merge 4 commits intoleftshift:masterfrom
Conversation
In order to make this look good, we need the browser to scale the canvas without interpolation. The CSS at least works for current Firefox, not at all sure about other browsers.
It's alright but here are some issues to consider for the future: - The DOM is stateful in waterfall mode (we store the previous states only in the canvas pixels). - Moving the speed slider causes spurious updates. - The patterns look very different depending on the amount of steps skipped per line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message of 231f2cf for remaining issues.