feat: Adds a diffeormorphism for the harmonic oscillator#1004
Open
jstoobysmith wants to merge 4 commits intomasterfrom
Open
feat: Adds a diffeormorphism for the harmonic oscillator#1004jstoobysmith wants to merge 4 commits intomasterfrom
jstoobysmith wants to merge 4 commits intomasterfrom
Conversation
zhikaip
reviewed
Mar 25, 2026
| invFun := toRealCLM | ||
| left_inv := by | ||
| intro t | ||
| cases t |
Collaborator
There was a problem hiding this comment.
Suggested change
| cases t |
shouldn't need cases t here
(goes into CauSeq.Completion.Cauchy abs which is totally irrelevant here)
Member
Author
There was a problem hiding this comment.
Thanks - agreed. I also realised it is probably a bit stupid to add this and not simultaneously convert to EuclideanSpace. So will do that as well here.
jstoobysmith
added
the
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a diffeomorphism for the harmonic oscillator configuration space.