style guide: Note on Unicode usage#820
Draft
adomasbaliuka wants to merge 1 commit intoleanprover-community:lean4from
Draft
style guide: Note on Unicode usage#820adomasbaliuka wants to merge 1 commit intoleanprover-community:lean4from
adomasbaliuka wants to merge 1 commit intoleanprover-community:lean4from
Conversation
adomasbaliuka
changed the title
| - invisible characters (except spaces and newlines) | ||
| - characters which modify other characters | ||
|
|
||
| Mathlib has a linter which checks all characters against an allow-list, to which new characters may be added as required. |
Collaborator
There was a problem hiding this comment.
Perhaps we could link to that allow-list once it's merged (assuming it will be located at a fairly stable location?).
Author
|
Contributor
|
I think the current draft is good enough. Thanks for writing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a proposed text-based linter which compares all Unicode characters in Mathlib to an allow-list, see leanprover-community/mathlib4#36773
This addition in the style-guide should explain good usage of Unicode.
Content and phrasing are up to debate.