Skip to content

Add @protected & @version#110

Open
botris wants to merge 1 commit intolanthaler:masterfrom
botris:context-update
Open

Add @protected & @version#110
botris wants to merge 1 commit intolanthaler:masterfrom
botris:context-update

Conversation

@botris
Copy link
Copy Markdown

@botris botris commented Oct 2, 2023

Json LD defines both protected and version, this PR adds both.

@k00ni
Copy link
Copy Markdown
Contributor

k00ni commented Oct 3, 2023

Good addition. Please add fixes #111 or add #111 in Development tab (right side), so it gets closed when this PR is merged.

@k00ni
Copy link
Copy Markdown
Contributor

k00ni commented Oct 10, 2023

Ping @lanthaler

@lanthaler
Copy link
Copy Markdown
Owner

lanthaler commented Oct 12, 2023

JsonLD is a 1.0 compliant parser, not 1.1. These changes break 1.0 compliance but don't make it 1.1 compliant as many of the new features will remain unsupported.

We thus unfortunately can't merge this in the current form. We either need to hide this behind a configuration flag or extend this PR to make JsonLD fully compliant with JSON-LD 1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants