Modarnization and Windows multi user fix#5
Conversation
…rove memory management
…er includes in header file
…put with logging function
Refactor: Remove package.json and enhance test output
Co-authored-by: draugvar <12036000+draugvar@users.noreply.github.com>
…espace Co-authored-by: draugvar <12036000+draugvar@users.noreply.github.com>
Co-authored-by: draugvar <12036000+draugvar@users.noreply.github.com>
Co-authored-by: draugvar <12036000+draugvar@users.noreply.github.com>
Modernize to C++20 with STL type safety improvements
…red memory functionality
…emory error handling
…SharedMemoryQueue initialization
…torageDirectory directly
fix-windows
feat: add CHANGELOG.md for version 1.7.0 and update README.md with new features
… on file create, just to be sure
Removed workflow_dispatch and push triggers from the build and test workflow.
acl setup with inheritance, clean handle close/set permissions/reopen…
change linux shm file perm to 777
|
WOW! This is a fantastic refactoring! Thank you @draugvar and @amassuoli Do you believe this is ready to merge? With the amount of work you've spent, I'd even go ahead and add you both as project members, so you can work on this project independently. |
|
Thanks Kyr0! |
|
This sounds amazing, @draugvar - I've added you to the members of the project. I believe that you should be able to see a pending invitation. With this, I believe, you should be able to even merge this PR. Please tell me, if the Merge button is available to you now (after accepting the invite). Thanks again for your contributions! |
|
Hi, Anyway, thanks for the invite. We firmly believe in open source contributions, so happy to give back. Anyway, for Windows use, the best course of action would be to go through a named file mapping instead of using a file - that's the appointed way to create shared memory there. Not that this way it doesn't work or that watchers aren't good for the job, the current situation can definitely do :) That's a thing to track for the future, maybe. Thanks for the kind words, and keep up the good work! |
|
Hi, I can confirm that the Merge pull request button is enabled. |
This pull request introduces several updates to modernize the codebase, streamline build and test processes, and improve automation. The most significant changes are upgrading the project to C++20, replacing legacy shell scripts with CMake-based workflows, and adding a comprehensive GitHub Actions CI/CD pipeline for building, testing, and releasing. Below are the most important changes grouped by theme.
Build System Modernization:
CMakeLists.txt,test/CMakeLists.txt, and related compiler flags to ensure compatibility across platforms. [1] [2] [3]build.sh,test.sh) and the Node.jspackage.jsonfile, consolidating build and test commands into CMake targets. [1] [2] [3]run_testfor running tests, improving integration with CI workflows.Continuous Integration & Release Automation:
.github/workflows/build_and_test.yml) to automate building, testing, and releasing the library on both Ubuntu and Windows, including dynamic version detection and release note generation.Documentation Updates:
README.mdto reflect the switch to C++20 and removed outdated build/test instructions, aligning documentation with the new build process. [1] [2]