Make sure proc file is closed when reading#111
Merged
ktbarrett merged 1 commit intoktbarrett:masterfrom Feb 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 66.98% 67.14% +0.15%
==========================================
Files 3 3
Lines 209 210 +1
Branches 51 51
==========================================
+ Hits 140 141 +1
Misses 51 51
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktbarrett
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running pytest against code that calls this library with strict warnings enabled, it fails due to proc being opened without close. In practice, I think readlines may be enough to close a file, but the
ResourceWarningshould still be avoided I guess.https://github.com/connectrpc/connect-python/actions/runs/21719459903/job/62644711295?pr=118