a11y: add keyboard operability to interface elements#1
Open
shkeating wants to merge 22 commits intoksadov:mainfrom
Open
a11y: add keyboard operability to interface elements#1shkeating wants to merge 22 commits intoksadov:mainfrom
shkeating wants to merge 22 commits intoksadov:mainfrom
Conversation
Author
|
oop I actually meant to only put this on my fork, but hi! I can edit this to just be the keyboard access changes and not the readme stuff if you are interested |
Owner
|
No worries! The keyboard accessibility stuff looks great, I'd love to merge that in. As far as the README goes I'd like to keep the Neocities example for this repo, but I do appreciate the Markdown correction for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested Changes
this branch edits the source code to make all elements keyboard operable. The original implementation used ul and li elements to show the interactive items, which prevented keybaord users from accessing them.