feat: handle focused guide key param in guide toolbar run config#888
Open
thomaswhyyou wants to merge 5 commits intomainfrom
Open
feat: handle focused guide key param in guide toolbar run config#888thomaswhyyou wants to merge 5 commits intomainfrom
thomaswhyyou wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ab4dfd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
thomaswhyyou
changed the title
thomaswhyyou
changed the title
Contributor
Author
|
@cursor review |
thomaswhyyou
requested review from
a team,
andy-knock and
connorlindsey
and removed request for
a team
connorlindsey
approved these changes
Mar 4, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 66.99% 67.06% +0.06%
==========================================
Files 207 207
Lines 9224 9245 +21
Branches 1238 1247 +9
==========================================
+ Hits 6180 6200 +20
- Misses 3020 3021 +1
Partials 24 24
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the
focused_guide_keyparam as part of the guide toolbar run config. This param is used in https://github.com/knocklabs/control/pull/7683 and https://github.com/knocklabs/control/pull/7687 when previewing an individual guide. Clicking on the Open preview button in dashboard opens a new tab with the configured preview url and sets the query param likefocused_guide_key=foo. And the changes here allows the toolbar to boot with the focused guide key, allowing it to force render that guide when it opens.Screenshots or videos
CleanShot.2026-03-04.at.11.13.57.mp4