fix: use install_modules_dependencies to fix compilation issues on RN 0.73 with Fabric#308
Merged
kirillzyusko merged 2 commits intomainfrom Feb 28, 2024
Merged
Conversation
Contributor
📊 Package size report
|
install_modules_dependencies to fix compilation issues on …install_modules_dependencies to fix compilation issues on RN 0.73 with Fabric
1 task
Owner
Author
|
Seems like fabric build is failing for RN < 0.73. I asked a question here lottie-react-native/lottie-react-native#1139 (comment) 👀 |
Owner
Author
|
We need to wait for new RN 0.72 version (see facebook/react-native#42075) to be released and after that we can update RN version in RNKC and merge this PR. |
2d163b4 to
9c31ae9
Compare
9c31ae9 to
00f2625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Started to use
install_modules_dependenciesin.podspec.💡 Motivation and Context
It's vital to use
install_modules_dependenciesbecause it simplifies integration process (this function is shipped in RN, so RN team cares about internal deps that could be provided to the project).So it means that we don't need to specify it manually anymore and instead we can rely on the implementation provided by the package.
However we need to keep in mind, that this function is available only from RN 0.71, so if we support RN < 0.71 we need to have fallback code.
The other aspect that was discovered during the implementation is the fact that this function was broken on RN 0.72 + Swift + New Arch combination, but with latest RN release it's not broken anymore (that's the reason why I updated a RN dependency in this PR - to verify that it actually works as expected).
Closes #371
📢 Changelog
JS
iOS
.podspecfile to useinstall_modules_dependenciesfunction.🤔 How Has This Been Tested?
Tested manually in reproduction example + via CI.
📝 Checklist