Allow saving images with URLs, and support Assets Library path when on The Forge#16
Open
rikmarais wants to merge 3 commits intokid2407:masterfrom
Open
Allow saving images with URLs, and support Assets Library path when on The Forge#16rikmarais wants to merge 3 commits intokid2407:masterfrom
rikmarais wants to merge 3 commits intokid2407:masterfrom
Conversation
When determining where the manifest and zip are hosted, use user specific Forge Assets Library path as resource path instead of window.location.origin
Add urlPathMap to map assets URL to URL.pathname for compendium data and for upload
rikmarais
changed the title
Author
|
Fixes #17 |
Author
|
The Forge specific fix relies on supporting URLs to be meaningful, so I have taken the liberty of including both functions in this PR Should you prefer to include the URL support code separately, please feel free to cherry pick/edit just 5545f00 and 2157f24 which introduce a new option which is only available if the first Image checkbox is already selected.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When determining where the manifest and zip are hosted specifically when using The Forge, use the user-specific Forge Assets Library path as resource path instead of
window.location.origin.This improves quality of life for
compendium2moduleusers on The Forge and allows them to access their manifest URL from CDN rather than server, and without their specific game currently online.