Add proxy support (desktop only)#23
Open
bommbomm34 wants to merge 6 commits intokdroidFilter:mainfrom
Open
Conversation
Currently, the proxy won't be updated if it's changed after webview creation.
Now, the proxy config can be changed after webview creation. The webview will be recreated in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxy support on Desktop
This pull request enables HTTP and SOCKS5 proxy support for desktop platforms (Windows, macOS and Linux). Android only supports a global proxy setting for all WebViews with
ProxyControllerand iOS withWKWebViewdoesn't seem to support it at all. I tested this change only on Linux.Changes
Public API
jvmProxyConfigparameter toWryWebViewPanel. This change could be potentially breaking.proxyConfigtoPlatformWebSettings.DesktopWebSettingsproxyConfigtoWebViewFactoryParamProxyConfigJvmProxyConfigInternal API
proxyoption tocreate_webview_with_user_agent,create_webviewandcreate_webview_innerin RustNativeBindingsNote
I don't know why there is a seperate
create_webview_with_user_agentmethod. I didn't make a seperate method for proxy config likecreate_webview_with_proxy_config.