fix(linux-rust): Retry L2CAP send on ENOTCONN during BlueZ Handshake#495
Open
Ap0ll02 wants to merge 1 commit intokavishdevar:linux/rustfrom
Open
fix(linux-rust): Retry L2CAP send on ENOTCONN during BlueZ Handshake#495Ap0ll02 wants to merge 1 commit intokavishdevar:linux/rustfrom
Ap0ll02 wants to merge 1 commit intokavishdevar:linux/rustfrom
Conversation
This fix allows the send thread to make 10 attempts to send it's data. This gives access to seeing the battery status
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When BlueZ reports the L2CAP connection as established, the kernel
socket isn't always ready to accept writes yet. The send_thread was
breaking on the first ENOTCONN (os error 107), killing the channel
before the handshake could complete. This caused all subsequent sends
(feature flags, notification request) to fail with "channel closed".
Fix
Retry up to 10 times with 100ms backoff specifically on ENOTCONN
before treating it as a fatal error. Any other error still kills
the thread immediately.
Related to #288