This repository was archived by the owner on Jun 22, 2020. It is now read-only.
[WIP] S2GRAPH-17: Remove unnecessary abstraction layer, Storage.#263
Open
[WIP] S2GRAPH-17: Remove unnecessary abstraction layer, Storage.#263
Conversation
Move PostProcess.scala to s2core from root project Move RequestParser from Root to s2core Make RestCaller for abstract over http layer Move root project to s2rest_play Move Test from root to s2core JIRA: [S2GRAPH-7] https://issues.apache.org/jira/browse/S2GRAPH-7 Pull Request: Closes #4
If we set s2graph.read-only.url on application.conf for s2counter_loader. We can read data from the read-only server. JIRA: [S2GRAPH-24] https://issues.apache.org/jira/browse/S2GRAPH-24 Pull Request: Closes #1
Remove Management.createService from Label/Service. Add Management class and move createService/createLabel/createTable from Management object into Management class. Refactor caller of above methods according to changes. JIRA: [S2GRAPH-14] https://issues.apache.org/jira/browse/S2GRAPH-14 Pull Request: Closes #2
Move common codes for rest into s2core.
Move test cases into s2core.
Add Netty server.
JIRA:
[S2GRAPH-9] https://issues.apache.org/jira/browse/S2GRAPH-9
Pull Request:
Closes #8
…t set-up command changes README update for refactoring. This resolves S2GRAPH-2. JIRA: [S2GRAPH-2] https://issues.apache.org/jira/browse/S2GRAPH-2 Pull Request: Closes #10 Authors: Hyunsung Jo: hyunsung.jo@gmail.com
…y mutable make consecutive fetch with different key.
# Conflicts: # s2core/lib/asynchbase-1.7.1-SNAPSHOT.jar # s2core/src/main/scala/com/kakao/s2graph/core/PostProcess.scala
Contributor
Author
|
@daewon plz review this, then I will update apache jira once we discuss the direction we should take for massive code changes. |
SteamShon
force-pushed
the
feature/merge_schema_v4
branch
from
cbb6f1d to
7f90114
Compare
… translate stored byte array into long type. so change IndexEdgeDeserializable to accept this function(with Bytes.toLong from HBase as default).
…sequence of KeyValues instead of single one.
# Conflicts: # s2core/src/main/scala/com/kakao/s2graph/core/rest/RestHandler.scala
…storage package from storage.hbase.
remove JsNumber.as[Double] on sortBy in PostProcess. JIRA: [S2GRAPH-11] https://issues.apache.org/jira/browse/S2GRAPH-11 Pull Request: Closes #5
Add InWithoutParent on Where parser for performance tunning. JIRA: [S2GRAPH-16] https://issues.apache.org/jira/browse/S2GRAPH-16 Pull Request: Closes #6
…est data from storage decoupled creating service/label from benchmark test cases. JIRA: [S2GRAPH-21] https://issues.apache.org/jira/browse/S2GRAPH-21 Pull Request: Closes #7
Remove the interval option was set twice. JIRA: [S2GRAPH-18] https://issues.apache.org/jira/browse/S2GRAPH-18 Pull Request: Closes #9
bug fix in query option "sample". JIRA: [S2GRAPH-20] https://issues.apache.org/jira/browse/S2GRAPH-20 Pull Request: Closes #12 Authors: Hyunsung Jo: hyunsung.jo@gmail.com
This resolves S2GRAPH-28. Renamed insertEdgesSync to mutateEdgesSync since deletions are also handled by this function. JIRA: [S2GRAPH-28] https://issues.apache.org/jira/browse/S2GRAPH-28 Pull Request: Closes #13 Authors: Hyunsung Jo: hyunsung.jo@gmail.com
remove ws, filters which is not necessary for s2core. add missing netty jar that is missed out on S2GRAPH-9. JIRA: [S2GRAPH-31] https://issues.apache.org/jira/browse/S2GRAPH-31 Pull Request: Closes #16
…s to run timeDecay function. provide options on query to specify property for timeDecay calculations. JIRA: [S2GRAPH-34] https://issues.apache.org/jira/browse/S2GRAPH-34 Pull Request: Closes #17
provide normalize operations on fetched QueryResult. JIRA: [S2GRAPH-35] https://issues.apache.org/jira/browse/S2GRAPH-35 Pull Request: Closes #18
add withWait on incrementCounts/mutateEdgesBulk move logics for deleteAll into s2core from rest project. bug fix for ignoring isAsync flag on label for deleteAll. change kafka message for deleteAll. JIRA: [S2GRAPH-36] https://issues.apache.org/jira/browse/S2GRAPH-36 Pull Request: Closes #19
Extract LockExpireDuration as configuration. note that default value for lock.expire.time = 600 secs. lock.expire.time > 2 * max.retry.number * max.back.off JIRA: [S2GRAPH-37] https://issues.apache.org/jira/browse/S2GRAPH-37 Pull Request: Closes #20
…degree edge too. skip convertEdges on degreeEdge. not include degreeEdge to exclude/include edges in filterEdges logic. JIRA: [S2GRAPH-38] https://issues.apache.org/jira/browse/S2GRAPH-38 Pull Request: Closes #21
… InnerVal. think this is more clear exception message JIRA: [S2GRAPH-39] https://issues.apache.org/jira/browse/S2GRAPH-39 Pull Request: Closes #22
…e value when edge's label schema version is different. use toString rather hashCode on different version of InnerVal v1 and v2 InnerVal use different bytes encoding scheme. JIRA: [S2GRAPH-40] https://issues.apache.org/jira/browse/S2GRAPH-40 Pull Request: Closes #23
seperate logic for buildRawEdges and buildResultJsValue on PostProcess. refactor options on query as queryOption. JIRA: [S2GRAPH-41] https://issues.apache.org/jira/browse/S2GRAPH-41 Pull Request: Closes #24
add pad to deal with different size on splitted tokens by on place holder and passed values on transform.
ex) [["age_band.slot.$.8", "age_band"]] should give "age_band.slot.${age_band}.8", not losing last ".8".
JIRA:
[S2GRAPH-42] https://issues.apache.org/jira/browse/S2GRAPH-42
Pull Request:
Closes #25
add check for columnFilter on queryParam. JIRA: [S2GRAPH-43] https://issues.apache.org/jira/browse/S2GRAPH-43 Pull Request: Closes #26
add RequestCache for WhereParser on Query. JIRA: [S2GRAPH-44] https://issues.apache.org/jira/browse/S2GRAPH-44 Pull Request: Closes #28
add TemplateHelper to deal with custom variable on query. JIRA: [S2GRAPH-32] https://issues.apache.org/jira/browse/S2GRAPH-32 Pull Request: Closes #27
pass impressionId from header into s2core so user can specify specific becket under experiment. JIRA: [S2GRAPH-45] https://issues.apache.org/jira/browse/S2GRAPH-45 Pull Request: Closes #29
add multiQuery support and refactor unused codes. JIRA: [S2GRAPH-33] https://issues.apache.org/jira/browse/S2GRAPH-33 Pull Request: Closes #30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first trial.