Feature: Detect cells without outer border when using the lines strategy for table detection#1342
Draft
DoomGuy77 wants to merge 21 commits intojsvine:developfrom
Draft
Feature: Detect cells without outer border when using the lines strategy for table detection#1342DoomGuy77 wants to merge 21 commits intojsvine:developfrom
DoomGuy77 wants to merge 21 commits intojsvine:developfrom
Conversation
|
thx for working on it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the feature discussed in #1325 by creating extra edges to close the borders of open tables. We found this easier to implement than @jsvine 's suggested approach.
We added an option in
TableOptionsfor whether to use this to close tablesNote that this is still a work in progress