chore: disable aarch64/darwin builds for now

[johnae]

No description provided.

[claude]

Claude finished @johnae's task —— View job

---

PR Review: chore: disable aarch64/darwin builds for now

Review Summary

This PR comments out the aarch64/darwin (Apple Silicon Mac) build configuration in the Buildkite pipeline. I've completed my review and here are my findings:

✅ Completed Review Tasks

• Examined the changed file (flake/buildkite-pipeline.nix)
• Reviewed for code quality and best practices
• Checked for potential bugs or issues
• Assessed performance considerations
• Evaluated security concerns
• Considered test coverage implications

Code Quality and Best Practices

✅ Clean commenting approach: The code is properly commented out using Nix comment syntax (#) rather than being deleted, making it easy to re-enable later.

✅ Consistent formatting: The commented sections maintain proper indentation, which is good for readability when uncommenting.

⚠️ Missing context: The PR lacks a description explaining WHY the aarch64/darwin builds are being disabled. This information would be valuable for future reference.

Potential Issues

⚠️ Impact on Mac users: Disabling Darwin builds means packages won't be built for macOS/Apple Silicon users. This could affect:

• Developers using M1/M2/M3 Macs
• CI/CD workflows that depend on Darwin builds
• Binary cache availability for Darwin systems

⚠️ Duplicate entry in darwinSkip: Line 51 contains a duplicate entry for "victoriametrics-logs-datasource-plugin" which should be cleaned up if this code is re-enabled.

Performance Considerations

✅ Reduced CI load: Removing Darwin builds will decrease CI runtime and resource usage, which could be beneficial if Darwin builds were causing bottlenecks or failures.

✅ Simplified pipeline: The pipeline now only handles x86_64-linux, reducing complexity.

Security Concerns

✅ No security issues identified: The changes don't introduce any security vulnerabilities.

Test Coverage

⚠️ Reduced platform coverage: Tests that would have run on Darwin platforms are now skipped, potentially missing platform-specific issues.

Recommendations

1. Add PR description: Document the reason for disabling Darwin builds (e.g., build failures, resource constraints, lack of Darwin runners).

2. Consider adding a TODO comment: Add a comment indicating when/under what conditions Darwin builds should be re-enabled:

   # TODO: Re-enable aarch64-darwin builds once [specific issue] is resolved
   # pkgs.aarch64-darwin = withSystem "aarch64-darwin" (

3. Clean up duplicate: Remove the duplicate "victoriametrics-logs-datasource-plugin" entry on line 51 when re-enabling.

4. Consider partial enablement: If only specific packages are problematic on Darwin, consider keeping Darwin builds enabled but expanding the darwinSkip list instead of disabling the entire platform.

Overall Assessment

The change is implemented correctly from a technical perspective, but lacks context about the motivation. While this is marked as a "chore" (routine maintenance), disabling an entire build platform is a significant change that warrants documentation for future maintainers.