Allow per-field overriding of default_operator#2
Open
cript0nauta wants to merge 1 commit intojmcarp:devfrom
Open
Allow per-field overriding of default_operator#2cript0nauta wants to merge 1 commit intojmcarp:devfrom
cript0nauta wants to merge 1 commit intojmcarp:devfrom
Conversation
So I can do something like this:
```python
class AlbumFilterSet(FilterSet):
class Meta:
model = Album
query = session.query(Album)
operators = (Equal, Greater, Less)
column_overrides = {
'name': {'default_operator': Like}
}
```
|
@jmcarp Any news on this fix? I also hit the same bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm thinking in using this library to refactor an existing RESTful API. I need to be able to override the
default_operatorattribute of some fields but not of all of them, but I noted that is not possible yet (thecolumn_overridesdoesn't use this). I wrote a simple fix for this issue.With this change I could do something like this: