Skip to content

respect args passed through cli conan cmds#3378

Merged
reshmifrog merged 5 commits intojfrog:masterfrom
reshmifrog:fix/conan-recipe-not-in-root-dir
Mar 13, 2026
Merged

respect args passed through cli conan cmds#3378
reshmifrog merged 5 commits intojfrog:masterfrom
reshmifrog:fix/conan-recipe-not-in-root-dir

Conversation

@reshmifrog
Copy link
Contributor

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Problem:
When running conan install --requires zlib/1.2.11 (without a conanfile.py or conanfile.txt), the JFrog CLI fails with the error "no conanfile.py or conanfile.txt found" because the build-info collection logic always expects a recipe file to exist, even though Conan 2.x officially supports installing dependencies directly via --requires and --tool-requires without any conanfile.
Solution:
Modified loadConanfile() in build-info-go to gracefully set default project metadata (name from directory, empty version, default user/channel) instead of failing when no conanfile is found. Updated buildGraphInfoArgs() to pass --requires and --tool-requires flags directly to conan graph info when no conanfile exists, and wired CLI overrides (--name, --version, --user, --channel) through jfrog-cli-artifactory so the build-info module ID can still be customized.

@reshmifrog reshmifrog added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 3, 2026
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 13, 2026
@reshmifrog reshmifrog force-pushed the fix/conan-recipe-not-in-root-dir branch from 4057837 to 3171790 Compare March 13, 2026 06:12
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 13, 2026
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 13, 2026
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 13, 2026
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Mar 13, 2026
@reshmifrog reshmifrog enabled auto-merge (squash) March 13, 2026 07:12
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@reshmifrog reshmifrog merged commit 2cc8241 into jfrog:master Mar 13, 2026
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants