Open
Conversation
|
considering this is a single file, standalone... do you think it is needed to have such docker setup? |
Owner
The script itself is only one file, but there are optional perl modules (as referenced by the ticket creator) that could be pulled in. Also, I imagine in some deploy environments that are optimized for Docker it would be nice to have even for a single file. I haven't thought yet about how to formally include this in the project but I support the general idea. |
|
fair enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi John, this PR adds support for Docker. Very useful in my case where I do tests on dev k8s cluster.
Also useful on any system with Docker that don't want to deal with installing CPAN/Perl and other extensions like Net-SSLeay.
Usage:
Example: