Add protocol conformance tests for Simulator and Scorer#49
Merged
jc-macdonald merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Test runtime_checkable isinstance for conforming and non-conforming classes, generate/score return types, config propagation, and an end-to-end Simulator→Scorer integration test. Relax ANN401, ARG002, PLR6301 for tests — needed for protocol stub classes. Closes #2
jc-macdonald
added
test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime-checkable protocol conformance tests for
SimulatorandScorer, plus a toy end-to-end integration test.Closes #2
Changes
Simulator protocol tests
isinstance(obj, Simulator)isinstancegenerate()returns a 2-tuplegenerate()propagates config values correctlyScorer protocol tests
isinstance(obj, Scorer)isinstancescore()returns adictwith expected keysfloatEnd-to-end
Config
ANN401,ARG002,PLR6301to test per-file ignores (needed for protocol stub classes)Stats
just cipasses (format, lint, mypy strict, coverage)