Use raw signature-params instead of self-construct one.#22
Open
Gh0u1L5 wants to merge 1 commit intojbowes:mainfrom
Open
Use raw signature-params instead of self-construct one.#22Gh0u1L5 wants to merge 1 commit intojbowes:mainfrom
Gh0u1L5 wants to merge 1 commit intojbowes:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the verifier uses a self-constructed "@signature-params" when verifying the signature. However, the order of signature params is not strictly defined in the standard.
For example, the following example is given in Section 2.3 of revision 19.
Next example is generated by Python library
requests-http-signature.Both of them are valid, but will fail our verification. So I suggest we can just use the raw params data to compose the signable.