Skip to content

Return 405 instead of 426 for HTTP requests to WebSocket endpoint #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davehorton merged 1 commit into from
Mar 17, 2026
Merged

Return 405 instead of 426 for HTTP requests to WebSocket endpoint #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions typescript/src/websocket/endpoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,15 @@ export function createEndpoint(opts: EndpointOptions): MakeService {
// Audio path registry (exact match — no prefix routing needed)
const audioRoutes = new Map<string, AudioClient>();

// Handle regular HTTP requests (OPTIONS for env var discovery, 426 for everything else)
// Handle regular HTTP requests (OPTIONS for env var discovery, 405 for everything else)
server.on('request', (req: http.IncomingMessage, res: http.ServerResponse) => {
if (req.method === 'OPTIONS' && envVars) {
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(JSON.stringify(envVars));
return;
}
res.writeHead(426, { 'Content-Type': 'text/plain' });
res.end('Upgrade Required');
res.writeHead(405, { 'Content-Type': 'text/plain' });
res.end('Method Not Allowed');
});

server.on('upgrade', (req: http.IncomingMessage, socket, head: Buffer) => {
Expand Down