Conversation
…shims, and code duplication Dead code removed: - Config entry stubs (listConfigEntries, 3 interfaces) — no backing DDL - BenchmarkRunner class — never instantiated - Deprecated task constants (LORE_SELF_TASKS, GSON_TASKS, POSTGRES_TASKS) - toSlug() in docs.ts — never called - 7 dead tool refs in benchmark script (coverage, routes, notes, etc.) - Deprecated parseAndExtract() helper — replaced by parseAndExtractStrict() Backward-compat shims removed: - Dual sync/async MCP server — consolidated to single async createLoreMcpServer() - buildToolModulesSync() and 14 eager tool imports — removed - ENRICHMENT_SCHEMA_MIGRATIONS + ensureEnrichmentSchema() — DDL already has all columns - hasSymbolMetricsTable/hasExternalSymbolsTable/hasTableColumn/getTableColumns/ externalSymbolSelectColumns — tables always exist - Defensive try-catch blocks in 4 commit query functions — let re- Defensive try-catch blocks in 4 commit query functions — let re- Defensive try-catch blocks in 4 commit query functions âdexer.ts — now imports fr- Defensives (fixes- Defensive try-catch blocks in 4 commit query functions — let re- Defan- Defensive try-catch blocks in 4 commit querr - Defensive try-catch blocks in 4 commit query functions — let re-dex-reader.ts All 1857 tests pass.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 87.54% 87.49% -0.06%
==========================================
Files 84 85 +1
Lines 9579 9475 -104
Branches 2958 2932 -26
==========================================
- Hits 8386 8290 -96
+ Misses 1193 1185 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Release Consolidation
Per CLAUDE.md: "No legacy code retention. Dead code, deprecated paths, compatibility shims, and migration layers should be removed rather than maintained."
This PR removes 851 net lines of dead code, backward-compatibility shims, and code duplication across 27 files.
Dead code removed
listConfigEntries, 3 interfaces) — no backing DDL ever existedBenchmarkRunnerclass — never instantiated anywhereLORE_SELF_TASKS,GSON_TASKS,POSTGRES_TASKS) — callers migrated togetTasksForRepo()toSlug()in docs.ts — never calledparseAndExtract()helper — sole caller migrated toparseAndExtractStrict()Backward-compat shims removed
createLoreMcpServer()is now async (was sync),createLoreMcpServerAsync()removed. CLI and standalone entry points updated toawait.buildToolModulesSync()and 14 eager tool imports in server.ts — removed; single source of truth intool-registry.tsENRICHMENT_SCHEMA_MIGRATIONSarray (44 entries) +ensureEnrichmentSchema()+hasTableColumn()— DDL already defines all columns inline;is_exportedcolumn added to DDL, enrichment indexes added to DDLhasSymbolMetricsTable(),hasExternalSymbolsTable(),getTableColumns(),externalSymbolSelectColumns()removed; queries now always joinsymbol_metricsand use hardcoded column list forexternal_symbolslistCommitRefs,listCommitsByRef,listCommitsBySemanticQuery,listCommitBranchActivity— real errors now surfaceCode duplication fixed
EXT_TO_LANGin scip-indexer.ts (missing 10 languages!) now imports from walker.tsFilePollerandFileWatcher) extracted to sharedScipFlushManagerclassextractReturnType()—lsp/enrichment.tsnow imports fromscip/index-reader.tsinstead of maintaining an identical copyTesting
All 1857 tests pass (69 skipped as expected). Test schemas updated to match the consolidated DDL.