chore: elevate branch coverage with non-extractor test gaps#174
Open
chore: elevate branch coverage with non-extractor test gaps#174
Conversation
…istry tests Cherry-picked from coverage/raise-to-85 (76d5833), minus the obsolete coverage.test.ts inline tests. - codecov.yml: raise project/patch targets to 85% - vitest.config.ts: add include pattern, raise thresholds - graph-analysis.test.ts: 15 tests for cycles/components/clusters/summary - runtime.test.ts: 10 tests for LoreRuntime lifecycle - tool-registry.test.ts: buildToolModules, loggedHandler, propertyToZod - server.test.ts: createLoreMcpServerAsync factory
…ch filtering, embedder edge cases - CLI: analyze subcommand (all modes), history-depth validation, language filter - graph-analysis: branch option filtering, empty methods array - embedder: LazyEmbeddingProvider failed-init dispose, dims throw Branch coverage: 74.08% → 75.24%
- complexity: parameter fallback walk when parameters field absent - config-parser: array values in JSON, unquoted values, nested objects Branch coverage: 75.34% → 75.47%
Tests for: listCommitCadence, listCommitSizes, listCommitChurnByFile, listCommitAuthorStats, listCommitMessagePrefixes, listCommitSchedule, listCommitBranchActivity with filter variations. Branch coverage: 75.47% → 76.05%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises CI coverage thresholds to 85% and closes the largest non-extractor test gaps. Supersedes #172 (the extractor inline tests from that PR are obsolete after #173's per-language fixture refactor).
Changes
Config
include: ["src/**/*.ts"]so uncovered files are counted. All 4 thresholds raised to 85%.New tests
tests/lore-server/tools/graph-analysis.test.tstests/runtime.test.tstests/lore-server/tool-registry.test.tsbuildToolModules,loggedHandlersuccess/error,propertyToZodedge casestests/lore-server/server.test.tscreateLoreMcpServerAsyncfactoryExpanded tests
tests/cli.test.tsanalyzesubcommand (all modes, validation), history-depth, language filtertests/indexer/embedder.test.tsLazyEmbeddingProviderfailed-init dispose, dims throwtests/indexer/graph-analysis.test.tstests/indexer/complexity.test.tstests/indexer/config-parser.test.tstests/lore-server/db.test.tslistCommitCadence/Sizes/ChurnByFile/AuthorStats/MessagePrefixes/Schedule/BranchActivitywith filter variationsRelationship to other PRs
coverage.test.tsextractor tests were dropped — they're obsolete after refactor(extractors): remove unnecessary conditionals and boost branch coverage #173 replaced them with per-language fixture-based tests.