Drop ply as external dependency and bundle it#128
Open
stratakis wants to merge 2 commits intoivelum:masterfrom
Open
Drop ply as external dependency and bundle it#128stratakis wants to merge 2 commits intoivelum:masterfrom
stratakis wants to merge 2 commits intoivelum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
This PR vendors ply up to its latest HEAD. The last 3.11 version contains a vulnerability (CVE-2025-56005) and while djangoql doesn't use the vulnerable pickle code, still not a good practice to bundle that, hence why I opted for the latest commit. Bundled only the parts used by djangoql and extracted the license, similarly to how projects like astropy or pypy do.
Noting here also that ply is archived and there will be no more bug fixes or releases (see dabeaz/ply@9d7c400) so ideally moving to a new parser (e.g. lark) would be a more sustainable solution, but obviously more work is required for implementing that.
Also removed parsetab.py which has been stale since d052abd and this mechanism is not used with the latest ply.