fid_proc support and various bug fixes#32
Conversation
|
Hi @headmeister, We'd love to get this PR integrated so that a downstream tool spec2nii can be updated to handle new PV360 versions. Any chance that you could take a look over the next few days? |
|
Hi, sorry @wtclarke I should somehow enable notifications for new pull requests... In any case, If I don't respond timely tag me as you did now so that I won't miss new updates. Anyways, I may need a bit more context. This is related to spectroscopic datasets only right? Since I have not seen these fid.64s fid_procs anywhere else. We should likely add tests for reading these as well later down the line then. But for now, I'd like to ask just to tidy up the commits a bit please. So if you could squash those that e.g. disable/reenable the file size checks would be nice. I believe this all might just fit into a single commit in the end. And ideally please fix the formatting issue, as with 2dseq just spread the fid_proc schema over multiple lines. Thanks for your contribution and once this is resolved I will approve this and create a new release. |
|
Hi @headmeister , Thanks for the quick and positive response. @VKarlaftis will look into squashing the commits together and the formatting issue. I think he also has a source of official Bruker test data which hopefully has some of the new fid format data. |
25cbdb1 to
d0cf6b5
Compare
|
Hi @headmeister. I've now squashed the commits. Re fid_proc.64 files. Yes, as I understand it, this is a Spectroscopy format and there is one available in the following repo: PS: This is the repo shared here: #25 |
|
Hi @VKarlaftis, ok thank you for squashing the commits, I see now. Its some form of processed fids, likely with phase correction... ok. We will then later also likely need the fid_refscan.64 won't we? I don't see a reason why this should block this PR though, just for future reference. Jiri. |
fid_proc.64files ('fid_proc' differs from 'fid' in regards to where the file is stored relative to the parameter_files, seeRELATIVE_PATHScode)unload_properties_validatemethod as all parameter_files were expected inside the parent folder instead of the specific paths defined inRELATIVE_PATHS.dwell_swhensw_hzis zero