Skip to content

Allow overriding inviwo/inviwo checkout ref without modifying the workflow#280

Merged
petersteneteg merged 6 commits intomasterfrom
copilot/add-inviwo-ref-input
Apr 2, 2026
Merged

Allow overriding inviwo/inviwo checkout ref without modifying the workflow#280
petersteneteg merged 6 commits intomasterfrom
copilot/add-inviwo-ref-input

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

Adds option to specify which inviwo ref to use with a comment

Copilot AI changed the title [WIP] Add inviwos ref input for dynamic branch cloning Allow overriding inviwo/inviwo checkout ref without modifying the workflow Apr 1, 2026
Copilot AI requested a review from petersteneteg April 1, 2026 12:33
@petersteneteg
Copy link
Copy Markdown
Member

@copilot pls address the CI issues

Agent-Logs-Url: https://github.com/inviwo/modules/sessions/a50c328b-f21a-4a0b-9b48-ca60ec10d4a6

Co-authored-by: petersteneteg <3638222+petersteneteg@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 1, 2026

@copilot pls address the CI issues

Fixed in b6950b9. The grep -oP (Perl regex) flag isn't available on macOS (BSD grep), which would cause failures in the build (macOS matrix) and regression (macOS runner) jobs. Replaced with a portable grep -oE '/inviwo-ref \S+' | sed 's|/inviwo-ref ||' pipeline that works on both Linux and macOS.

@petersteneteg petersteneteg marked this pull request as ready for review April 1, 2026 13:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

github-actions[bot]
github-actions bot previously approved these changes Apr 1, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@github-actions github-actions bot dismissed their stale review April 1, 2026 17:15

outdated suggestion

github-actions[bot]
github-actions bot previously approved these changes Apr 1, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@petersteneteg
Copy link
Copy Markdown
Member

@copilot there is some CI issue when we don't hava a /inviwo-ref set

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 2, 2026

@copilot there is some CI issue when we don't hava a /inviwo-ref set

Fixed in 8c7bdf5. The shell runs with set -e -o pipefail, so when grep -oE finds no /inviwo-ref token in the PR body it exits with code 1, which caused the whole step to fail. Added || true to all three occurrences so a no-match is handled gracefully and falls through to the master default.

@github-actions github-actions bot dismissed their stale review April 2, 2026 06:44

outdated suggestion

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@petersteneteg petersteneteg merged commit 604b1de into master Apr 2, 2026
34 of 35 checks passed
@petersteneteg petersteneteg deleted the copilot/add-inviwo-ref-input branch April 2, 2026 16:40
github-actions bot pushed a commit to inviwo/regression that referenced this pull request Apr 2, 2026
martinfalk pushed a commit that referenced this pull request Apr 9, 2026
Allow overriding inviwo/inviwo checkout ref without modifying the workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants