[mock_uss] Regular cleanup of outdated flights#1364
Open
the-glu wants to merge 1 commit intointeruss:mainfrom
Open
[mock_uss] Regular cleanup of outdated flights#1364the-glu wants to merge 1 commit intointeruss:mainfrom
the-glu wants to merge 1 commit intointeruss:mainfrom
Conversation
the-glu
force-pushed
the
garbage_collection_on_mocks_3
branch
from
2528aca to
b4bf02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a regular cleaning job of flights and operational intents in mock_uss/flights/database.
Idea is to prevent building-up of flights if mock uss stay up for a long time. Memory is still limited (in
SynchronizedValue), but it should help for #1059.Interval values has been set arbitrary, they should work most of the time and don't interfere with regular tests.
I switched to a period task instead of having manual calls everywhere (including notifications).
Similar changes should be done for ridsp database as we do have flights that can build-up there. For others instances of databases, we could have build-up of elements but we don't have time information (e.g. riddp has only flight urls).