feat(remote-sync): refactor remote sync process#298
Open
egalvis27 wants to merge 3 commits intofeat/unify-project-system-pathsfrom
Open
feat(remote-sync): refactor remote sync process#298egalvis27 wants to merge 3 commits intofeat/unify-project-system-pathsfrom
egalvis27 wants to merge 3 commits intofeat/unify-project-system-pathsfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is Changed / Added
This PR refactors the
remote-syncmodule to make the flow more explicit, more functional, and easier to maintain.The previous implementation was centered around a large stateful manager-like structure with multiple responsibilities mixed together. This change breaks that logic into smaller focused modules, clarifies the runtime orchestration layer, and reduces cross-layer coupling between
contextandapps/main.What Changed
Remote sync controller refactor
remote-sync-controllermodule.localIsSynced.startRemoteSyncis executed, instead of being stored unnecessarily in the controller factory.Error handling cleanup
Contract and boundary cleanup
contextlayer.context -> apps/main/remote-sync/servicedependency by routing access through a shared remote sync service contract.Naming and structure improvements
managernaming withcontrollernaming across the remote sync slice.Behavior fixes
SQLiteRemoteItemsGeneratorwhen mapping nullable DTO file types intoServerFile.