[libspirv][NFC] Fix license in native_log.cl native_log2.cl#21587
Open
wenju-he wants to merge 1 commit intointel:syclfrom
Open
[libspirv][NFC] Fix license in native_log.cl native_log2.cl#21587wenju-he wants to merge 1 commit intointel:syclfrom
wenju-he wants to merge 1 commit intointel:syclfrom
Conversation
Fix it because libclc isn't using `Advanced Micro Devices` license.
Maetveis
requested changes
Mar 23, 2026
Contributor
Maetveis
left a comment
Maetveis
left a comment
There was a problem hiding this comment.
I'm not sure if simply replacing AMD's license with the LLVM one like that without any attribution is okay or not. I assume the license was there because (parts of) the implementation is taken from AMD. That probably requires some kind of attribution at the least, I think, but I'm not a lawyer of course.
Maetveis
approved these changes
Mar 23, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix it because libclc isn't using
Advanced Micro Deviceslicense.