Fix LCC25 voltage min step value to 1mV#451
Conversation
|
looks like I have something to fix first, probably a dependency that updated.... |
|
I am not sure what happened. The diff is just 5 instances of changing a 1 for a 3. I suspect it is because I tried to make pr from a computer where I have to use windows store python and pre-commit has problems with that. I will try the PR from my Linux machine tomorrow |
|
can you try merging the latest main into your branch? |
|
perfect, now the errors are actual test failures related to your change. |
|
I updated the test to reflect the change to the instrument resolution. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 95 95
Lines 9596 9596
=======================================
Hits 9519 9519
Misses 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scasagrande
left a comment
There was a problem hiding this comment.
thanks for the patch!
Modified lcc25.py to make the script match the stepsize of the instrument LCC25 by modifying the associated f-string.