Added support for a new option ignored_path_patterns#3
Open
adam-golab wants to merge 2 commits intoinstrumenta:masterfrom
Open
Added support for a new option ignored_path_patterns#3adam-golab wants to merge 2 commits intoinstrumenta:masterfrom
adam-golab wants to merge 2 commits intoinstrumenta:masterfrom
Conversation
|
@garethr @adam-golab anything blocking this from being merged? |
joshuaspence
added a commit
to joshuaspence/homelab
that referenced
this pull request
Aug 15, 2020
Pointing to instrumenta/kubeval-action#3 instead of `master`.
joshuaspence
added a commit
to joshuaspence/homelab
that referenced
this pull request
Aug 15, 2020
Pointing to instrumenta/kubeval-action#3 instead of `master`.
|
hi, team ignored path pattern is extremely helpful. How is this patch progress? |
|
Ping ping |
|
Bueller? |
|
Does anyone have an alternate method to add ignored_path_patterns till it is merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly I've added a new support for option introduced in this PR: instrumenta/kubeval#192, but during my testing, I've found that this options doesn't really works with my requirements. So I modified the original feature in the
kubevalrepo, where I changed it a little bit, more info here: instrumenta/kubeval#235.This PR adds support for configuring that option in the yaml configuration file for Github Actions