Skip to content

fix _no_split_modules subscript error for transformers v5 #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxusmusti merged 1 commit into from
Feb 11, 2026
Merged

fix _no_split_modules subscript error for transformers v5 #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/instructlab/training/accelerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def __getattr__(self, name):

def get_fsdp_config(self):
is_lora = self.model.lora_config is not None
block_name = self.model._no_split_modules[0]
block_name = next(iter(self.model._no_split_modules))

wrap_policy = None
if is_lora > 0:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_accelerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def mock_model():
model = MagicMock(spec=Model)
model.model = MagicMock()
model.lora_config = None
model._no_split_modules = ["LlamaDecoderLayer"]
model._no_split_modules = {"LlamaDecoderLayer"}
# Add children method to model
model.children = MagicMock(return_value=[])
model.model.children = MagicMock(return_value=[])
Expand Down
Loading