Open
Conversation
d6b62d8 to
719c042
Compare
719c042 to
202be94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #85
Right now, I have a messy
docker runscript.Maybe this would be cleaner if I added a new
servicein the compose file, built from./Dockerfile, start it withsleep infinityas the command, anddocker compose execinto it instead of running a new container every time. We could then use docker-compose for the networking between containers, usedepends_onand healthchecks to wait for the db to be up (instead ofuntil psql 'select 1;' do sleep 1; done, and so on.Problems with current implementation:
ubuntu20- but I prefer if I can fix it through explicitly installing and configuring Java on the official docker python image (Debian)localhost?